BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

Improved case-insensitive match to account for special characters. #277

Closed crisely09 closed 1 year ago

crisely09 commented 1 year ago

Related to https://github.com/BlueBrain/nexus-forge/issues/276 Added some changes to detect special characters and account them in the the Filter regex SPARQL query.

lecriste commented 1 year ago

I tested this PR with a few labels and it's working fine, thanks!

codecov-commenter commented 1 year ago

Codecov Report

Merging #277 (757a7f3) into master (f2d914d) will increase coverage by 0.22%. The diff coverage is 66.10%.

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   72.35%   72.58%   +0.22%     
==========================================
  Files          85       86       +1     
  Lines        5303     5340      +37     
==========================================
+ Hits         3837     3876      +39     
+ Misses       1466     1464       -2     
Impacted Files Coverage Δ
...gforge/specializations/resolvers/agent_resolver.py 42.85% <18.18%> (+2.43%) :arrow_up:
...rge/specializations/resolvers/ontology_resolver.py 46.00% <18.18%> (+5.61%) :arrow_up:
tests/core/test_resolving.py 94.11% <94.11%> (ø)
kgforge/core/archetypes/resolver.py 61.53% <95.00%> (+9.42%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.