search

BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

Enable debug option for pyschacl validation #281

Open crisely09 opened 1 year ago

crisely09 commented 1 year ago

In the effort to solve https://github.com/BlueBrain/nexus-forge/issues/280 this option let's us use the debug version of the pyschacl validator.

codecov-commenter commented 1 year ago

Codecov Report

Merging #281 (3e3fe1a) into master (a1f7242) will decrease coverage by 0.23%. The diff coverage is 48.68%.

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   72.62%   72.40%   -0.23%     
==========================================
  Files          90       90              
  Lines        5761     5787      +26     
==========================================
+ Hits         4184     4190       +6     
- Misses       1577     1597      +20
Flag Coverage Δ
unittests 72.40% <48.68%> (-0.23%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
kgforge/specializations/stores/bluebrain_nexus.py 26.53% <18.18%> (-0.49%) :arrow_down:
kgforge/core/forge.py 64.51% <33.33%> (-0.87%) :arrow_down:
...gforge/specializations/models/rdf/store_service.py 20.56% <50.00%> (ø)
kgforge/core/archetypes/model.py 57.14% <100.00%> (ø)
kgforge/core/archetypes/store.py 58.98% <100.00%> (ø)
kgforge/specializations/models/demo_model.py 67.05% <100.00%> (ø)
...ge/specializations/models/rdf/directory_service.py 92.15% <100.00%> (ø)
kgforge/specializations/models/rdf/service.py 87.34% <100.00%> (ø)
kgforge/specializations/models/rdf_model.py 82.55% <100.00%> (ø)
tests/specializations/models/test_demo_model.py 100.00% <100.00%> (ø)
... and 1 more
crisely09 commented 1 year ago

I haven't implemented yet the option to delete distributions and deprecate files when registration fails. I would rather put that in a separate PR.

joni-herttuainen commented 1 year ago

I was testing the newest changes, and we're discussing about it in NSETM-2067.

Instead of opening a new ticket, I'll relay a comment from @jdcourcol, before this is pushed to master:

This is not great. "RegistrationError" does not bring any information when you are "Registering". The client knows that he is registering. It should be a "ValidationError" exception instead. And then having the information as text is unusable for programmatic access.