search

BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

Removed limit in sparql and elastic when not given. Removed unnecessary arguments #287

Closed crisely09 closed 1 year ago

crisely09 commented 1 year ago

This is a little effort to address two issues: https://github.com/BlueBrain/nexus-forge/issues/241 and https://github.com/BlueBrain/nexus-forge/issues/262 Basically by not rewriting the offset and limit when they are given as None.

codecov-commenter commented 1 year ago

Codecov Report

Merging #287 (161edfd) into master (49a5623) will decrease coverage by 0.05%. The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   72.57%   72.52%   -0.05%     
==========================================
  Files          86       86              
  Lines        5341     5347       +6     
==========================================
+ Hits         3876     3878       +2     
- Misses       1465     1469       +4
Impacted Files Coverage Δ
kgforge/core/archetypes/store.py 61.38% <28.57%> (-0.86%) :arrow_down:
kgforge/specializations/stores/bluebrain_nexus.py 27.71% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

crisely09 commented 1 year ago

I just added a couple of examples of the use-cases for those parameters to the getting-started notebooks.

crisely09 commented 1 year ago

@ssssarah could you take another look, please?