Closed crisely09 closed 1 year ago
@MFSY this is ready to be reviewed
Merging #290 (7fd2d51) into master (3a9d774) will increase coverage by
0.17%
. The diff coverage is65.17%
.
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
+ Coverage 72.68% 72.85% +0.17%
==========================================
Files 86 88 +2
Lines 5499 5574 +75
==========================================
+ Hits 3997 4061 +64
- Misses 1502 1513 +11
Impacted Files | Coverage Δ | |
---|---|---|
kgentitylinkingsklearn/entity_linking_sklearn.py | 0.00% <0.00%> (ø) |
|
..._linking/service/entity_linking_elastic_service.py | 37.73% <0.00%> (-0.73%) |
:arrow_down: |
kgforge/specializations/resolvers/store_service.py | 21.42% <13.63%> (-9.61%) |
:arrow_down: |
...gforge/specializations/resolvers/agent_resolver.py | 58.97% <35.71%> (+16.11%) |
:arrow_up: |
...rge/specializations/resolvers/ontology_resolver.py | 59.45% <42.85%> (+14.36%) |
:arrow_up: |
kgforge/specializations/stores/bluebrain_nexus.py | 22.34% <50.00%> (-5.03%) |
:arrow_down: |
kgforge/specializations/resolvers/demo_resolver.py | 47.76% <57.14%> (-1.45%) |
:arrow_down: |
.../resolvers/entity_linking/entity_linker_elastic.py | 62.06% <62.50%> (-5.94%) |
:arrow_down: |
kgforge/core/archetypes/resolver.py | 64.39% <74.46%> (+2.85%) |
:arrow_up: |
kgforge/core/commons/sparql_query_builder.py | 92.98% <92.98%> (ø) |
|
... and 7 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@MFSY this is ready to be reviewed
I proposed to use the existing resolving 'target' as a way to specify the ontology to resolve to.
@MFSY Done, now it uses a dictionary. I also changed filter
to filters
because we are assuming that we can have more than one.
The option to search within an ontology was added inside the configuration file, and the parameter to trigger this is
resolving_context
which should match one of thecontexts
names provided in the configuration. Done: