search

BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

GROUP BY, ORDER, MINUS Sparql keywords to be ignored by rewriter #292

Closed ssssarah closed 1 year ago

ssssarah commented 1 year ago

Any idea why there is there is that "new_base variable used before assignment" error when the tests run?

MFSY commented 1 year ago

Any idea why there is there is that "new_base variable used before assignment" error when the tests run?

I suspect the new rdflib releases 6.3.X are introducing this error. @ssssarah set the rdflib version to 6.2.0. until we sort this out.

crisely09 commented 1 year ago

Any idea why there is there is that "new_base variable used before assignment" error when the tests run?

I suspect the new rdflib releases 6.3.X are introducing this error. @ssssarah set the rdflib version to 6.2.0. until we sort this out.

Yes, this is related to my PR https://github.com/BlueBrain/nexus-forge/pull/295 , I also opened an issue on the rdflib side.

codecov-commenter commented 1 year ago

Codecov Report

Merging #292 (5ed645e) into master (f23f3d4) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   72.52%   72.52%           
=======================================
  Files          86       86           
  Lines        5347     5347           
=======================================
  Hits         3878     3878           
  Misses       1469     1469
Impacted Files Coverage Δ
kgforge/core/archetypes/store.py 61.38% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.