search

BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

Upgrading to python 3.8 #296

Closed crisely09 closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #296 (30f9b35) into master (7495918) will increase coverage by 0.54%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   72.52%   73.07%   +0.54%     
==========================================
  Files          86       86              
  Lines        5347     5456     +109     
==========================================
+ Hits         3878     3987     +109     
  Misses       1469     1469
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

... and 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

MFSY commented 1 year ago

Shouldn't publish use python 3.8 as well ?

crisely09 commented 1 year ago

Shouldn't publish use python 3.8 as well ?

Yes, I missed to add it to the commit.

lecriste commented 1 year ago

This is breaking the BMO pipeline because BMO is on python 3.7 and uses the latest nexus-forge. Shall we upgrade the BMO python too or use a compatible nexus-forge tag?