Use `scikit-learn` instead of `sklearn` for "linking_sklearn" extra

BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy

https://nexus-forge.readthedocs.io

GNU Lesser General Public License v3.0

38 stars 19 forks source link

Use `scikit-learn` instead of `sklearn` for "linking_sklearn" extra #301

Closed kysrpex closed 1 year ago

kysrpex commented 1 year ago

Building the docker image on Binder may fail because package sklearn is deprecated. The package has been renamed to scikit-learn.

The failure cannot be reliably reproduced because the installation of sklearn will only raise an exception during specific time windows. See section "Brownout schedule" on https://pypi.org/project/sklearn/.

This PR replaces sklearn with scikit-learn.

crisely09 commented 1 year ago

Hi @kysrpex , sorry for the delay. Could you just rebase it? Thank you.

crisely09 commented 1 year ago

Hi @kysrpex , I noticed that this was implemented in this line Just for future reference, if you are not part of the Blue Brain project, a Contributor License Agreement (CLA) must be signed for any code changes to be accepted. Please contact us here to get the latest CLA version and instructions if you are interested.