BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

Added Graph to SPARQL resolve query to avoid doble labels #310

Closed crisely09 closed 1 year ago

crisely09 commented 1 year ago

Addresses this issue: https://github.com/BlueBrain/nexus-forge/issues/309

See example notebook.

crisely09 commented 1 year ago

@MFSY this does what you said, you can run some tests, I added the two cases we encountered to the Resolving Strategies notebook.

crisely09 commented 1 year ago

@MFSY, I think we need to add:

  token: ${{ secrets.CODECOV_TOKEN }}

to the test configuration, if we want the codecov to stop failing

codecov-commenter commented 1 year ago

Codecov Report

Merging #310 (fe514b5) into master (e5838e9) will decrease coverage by 0.05%. The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   72.67%   72.63%   -0.05%     
==========================================
  Files          88       88              
  Lines        5622     5627       +5     
==========================================
+ Hits         4086     4087       +1     
- Misses       1536     1540       +4     
Flag Coverage Δ
unittests 72.63% <20.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gforge/specializations/resolvers/agent_resolver.py 58.97% <ø> (ø)
kgforge/specializations/resolvers/demo_resolver.py 47.76% <ø> (ø)
...izations/resolvers/entity_linking/entity_linker.py 47.82% <ø> (ø)
...rge/specializations/resolvers/ontology_resolver.py 56.41% <0.00%> (-3.05%) :arrow_down:
kgforge/specializations/stores/nexus/service.py 56.22% <33.33%> (-0.27%) :arrow_down:
MFSY commented 1 year ago

token: ${{ secrets.CODECOV_TOKEN }}

How can we get a token ?

crisely09 commented 1 year ago

I would expect is the same as for version 2:

https://about.codecov.io/blog/getting-started-with-the-codecov-api-v2/

MFSY commented 1 year ago

Okay. Added in #311 a CODECOV_TOKEN as secret and used it in test github action. Let see if it works