search

BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

Enabled resolvers mapping files to contains rules calling a forge method #323

Closed MFSY closed 1 year ago

MFSY commented 1 year ago

Fixes #316

codecov-commenter commented 1 year ago

Codecov Report

Merging #323 (20ae01b) into master (172fc34) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   72.62%   72.62%           
=======================================
  Files          90       90           
  Lines        5761     5761           
=======================================
  Hits         4184     4184           
  Misses       1577     1577
Flag Coverage Δ
unittests 72.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
kgforge/core/archetypes/resolver.py 64.39% <0.00%> (ø)
kgforge/core/forge.py 65.38% <ø> (ø)
MFSY commented 1 year ago

Could you add an example or a test?

This is to match how mappers are invoked in this merged PR https://github.com/BlueBrain/nexus-forge/pull/315/files#diff-c86c44807067dc2a80f4c2bcfa7aa9ec26c580888cc7fbba71032bb14736c73f.

A forge instance should be passed when calling mapper(forge).map()

do we have already a case where the hjson has a forge function?

There is not yet a configured resolver with a mapping file using a forge method. But this is a matter of time.