BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

Raised an exception when a jsonld dict with an @id containing space character is provided to from_jsonld #330

Closed MFSY closed 12 months ago

MFSY commented 12 months ago

rdflib.plugins.shared.jsonld.context.Context.resolve(iri) return "" when iri contains space. This leads to silently replacing an iri with "" in _remove_ld_keys.

codecov-commenter commented 12 months ago

Codecov Report

Merging #330 (7688bed) into master (a936ef1) will increase coverage by 0.08%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   72.73%   72.81%   +0.07%     
==========================================
  Files          90       90              
  Lines        5777     5794      +17     
==========================================
+ Hits         4202     4219      +17     
  Misses       1575     1575              
Flag Coverage Δ
unittests 72.81% <100.00%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
kgforge/core/conversions/rdf.py 87.90% <100.00%> (+0.20%) :arrow_up:
tests/core/conversions/test_rdf.py 100.00% <100.00%> (ø)