search

BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

Upgrade pyshacl and replace Validator with validate function #338

Closed crisely09 closed 10 months ago

crisely09 commented 11 months ago

Use the latest version of pyshacl, and replace object with newer method.

codecov-commenter commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fc6177c) 73.44% compared to head (ecd68ce) 73.45%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #338 +/- ## ======================================= Coverage 73.44% 73.45% ======================================= Files 91 91 Lines 5833 5831 -2 ======================================= - Hits 4284 4283 -1 + Misses 1549 1548 -1 ``` | [Flag](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/338/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/338/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | `73.45% <75.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [...ge/specializations/models/rdf/directory\_service.py](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#diff-a2dmb3JnZS9zcGVjaWFsaXphdGlvbnMvbW9kZWxzL3JkZi9kaXJlY3Rvcnlfc2VydmljZS5weQ==) | `92.00% <100.00%> (-0.16%)` | :arrow_down: | | [setup.py](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#diff-c2V0dXAucHk=) | `0.00% <ø> (ø)` | | | [...gforge/specializations/models/rdf/store\_service.py](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#diff-a2dmb3JnZS9zcGVjaWFsaXphdGlvbnMvbW9kZWxzL3JkZi9zdG9yZV9zZXJ2aWNlLnB5) | `20.75% <50.00%> (+0.19%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crisely09 commented 11 months ago

@MFSY this is also ready for review.

crisely09 commented 11 months ago

This might me causing the error that I was seeing when resolving brain regions:

REGION:  hypothalamus
<action> parse
<error> ParserError: Invalid line: ^^http://www.w3.org/2001/XMLSchema#integer .
MFSY commented 10 months ago

This might me causing the error that I was seeing when resolving brain regions:

REGION:  hypothalamus
<action> parse
<error> ParserError: Invalid line: ^^http://www.w3.org/2001/XMLSchema#integer .

Fixed in https://github.com/BlueBrain/nexus-forge/pull/340