Closed ssssarah closed 8 months ago
Attention: 115 lines
in your changes are missing coverage. Please review.
Comparison is base (
cece1ce
) 73.45% compared to head (4808f76
) 73.52%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is not a bad idea, but now that we are looking into the services, maybe we also avoid initializing the same store/service multiple times when creating a forge instance, what do you think?
Agreed but I see this as a first step in improving readability, I'm not changing much in terms of functionality and features. I think it would help to get a clearer picture of the dependencies of models and resolvers on their own store instances
Services are being initialised in Resolver, Store and Model but there was no typing and abstraction that defined what these services were. In this PR, there some reorganising of where the services are, what classes they extend, and which classes can be used as a service for the Resolver, Store and Model