Open ssssarah opened 10 months ago
Attention: 69 lines
in your changes are missing coverage. Please review.
Comparison is base (
2e616cd
) 74.36% compared to head (e05ca33
) 74.45%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hasn't been updated in a while, out of sync, to refresh
DKE-1239
Model
archetype.get_context_prefix_vocab
abstract method toModel
archetype: the reason for this is that when rewriting sparql queries, you need to use the context. However,BlueBrainNexus
(the store) cannot simply just use aContext
object, because it is merging the metadata context's document with the data context's document, and keeping data context's vocab, and the data context's prefixes. As a result, if you want to use theSparqlQueryBuilder
(to do sparql queries, which is what we're trying to enable), you need to implement this function that returns prefixes, a context document (as a dict) and prefixes.Context
into a dict from theReadOnlyStore
to theContext
class: formatting theContext
is no longer just aReadOnlyStore
's concern, but aModel
may need to as well. In any case, it's the manipulation of aContext
, so it makes sense for it to live there.get_model
andget_store
accessors inKnowledgeGraphForge
RdfModelService
:_build_shapes_map
method to implement: it returns the shapes into a Graph, a dictionary indicating the source the shape originates from, and a dictionary that says which class is constrained by which shape. By centralizing it in the same method (which was not the case before), it enables knowing which file contained which schema (for the implementation inRdfModelServiceFromDirectory
)RdfModelServiceFromDirectory
: formerly namedDirectoryService
,get_shape_source
can now be implemented (formerly namedschema_source_id
) due to the change inRdfModelService
base classspecializations.stores.service
: bug with the context cache not being used fixed