Closed ssssarah closed 9 months ago
Oh, but I think they should return the mappings if they exist, not None
Yes but that changes the behavior of things. I just made this for code quality
OK, now they are consistent, they are either returned as strings or as dict, not both, correct?
The way I understand it is that if you specify pretty=True then you want it to be in the standard output stream and nothing is being returned, and it it's false you want it as a dict. But it's never returned as a str. I'm not against it but my goal with the MR was just to be explicit about the returning of nothing, not to change behavior
Some functions in the model archetype were returning an optional string, but for some cases in if statements there were no return statements