BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

More linting #355

Closed ssssarah closed 8 months ago

ssssarah commented 9 months ago
codecov-commenter commented 9 months ago

Codecov Report

Attention: 159 lines in your changes are missing coverage. Please review.

Comparison is base (4d2580e) 74.42% compared to head (16e50d1) 74.46%.

Files Patch % Lines
kgforge/specializations/stores/demo_store.py 30.76% 36 Missing :warning:
kgforge/core/archetypes/model.py 51.61% 15 Missing :warning:
kgforge/core/archetypes/resolver.py 62.96% 10 Missing :warning:
kgforge/core/archetypes/store.py 52.38% 10 Missing :warning:
kgforge/core/conversions/rdf.py 33.33% 8 Missing :warning:
kgforge/specializations/models/demo_model.py 68.18% 7 Missing :warning:
kgforge/core/archetypes/read_only_store.py 50.00% 6 Missing :warning:
kgforge/specializations/models/rdf_model.py 66.66% 6 Missing :warning:
kgforge/specializations/stores/bluebrain_nexus.py 60.00% 6 Missing :warning:
kgforge/specializations/stores/sparql_store.py 45.45% 6 Missing :warning:
... and 20 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #355 +/- ## ========================================== + Coverage 74.42% 74.46% +0.03% ========================================== Files 100 100 Lines 6213 6293 +80 ========================================== + Hits 4624 4686 +62 - Misses 1589 1607 +18 ``` | [Flag](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/355/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/355/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | `74.46% <56.43%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crisely09 commented 9 months ago

These are small but wide changes, can we merge this after the archetypes change?

ssssarah commented 9 months ago

These are small but wide changes, can we merge this after the archetypes change?

Yeah of course, archetypes > everything else