search

BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 20 forks source link

Load local configuration when configuration tests #370

Closed ssssarah closed 6 months ago

ssssarah commented 6 months ago

When running tests that initialise the BlueBrainNexus store, load store configuration from ./examples/notebooks/use-cases/prod-forge-nexus.yml

codecov-commenter commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2e616cd) 74.36% compared to head (b63ead5) 74.52%.

Files Patch % Lines
kgforge/core/forge.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #370 +/- ## ========================================== + Coverage 74.36% 74.52% +0.16% ========================================== Files 100 100 Lines 6315 6332 +17 ========================================== + Hits 4696 4719 +23 + Misses 1619 1613 -6 ``` | [Flag](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/370/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/370/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | `74.52% <96.15%> (+0.16%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crisely09 commented 6 months ago

Would it make sense to add here the change mentioned today: use a particular path as default to load a local configuration? instead of fetching the raw file from GitHub

ssssarah commented 6 months ago

Would it make sense to add here the change mentioned today: use a particular path as default to load a local configuration? instead of fetching the raw file from GitHub

This MR only deals with configurations used in tests. And it's only picking subparts of the configuration. I think the default configuration thing should happen, but it doesn't feel relevant to this MR.