Closed ssssarah closed 8 months ago
Attention: 16 lines
in your changes are missing coverage. Please review.
Comparison is base (
8a900ec
) 74.52% compared to head (691a1c9
) 74.51%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
looks good, could you provide either a test or expand the query example notebook to use the view
parameter?
I would probably update the notebooks, as there are no unit tests for querying
I would probably update the notebooks, as there are no unit tests for querying
Please provide unit tests for this change.
I would probably update the notebooks, as there are no unit tests for querying
Please provide unit tests for this change.
There are no unit tests for querying currently, and this feature only checks the existence of an extra keyword argument, before doing the request.post call, so it's not even behavior that is isolated and can be tested through unit tests
I could make a unit test on https://github.com/BlueBrain/nexus-forge/blob/4fde40c8514769cb851bf620e3148586bae61920/kgforge/specializations/stores/nexus/service.py#L218 though
I could make a unit test on
though
Please do
I could make a unit test on https://github.com/BlueBrain/nexus-forge/blob/4fde40c8514769cb851bf620e3148586bae61920/kgforge/specializations/stores/nexus/service.py#L218
though
Please do
Just added it
Feature to be able to specify a view when calling forge.sparql, forge.elastic and forge.search, instead of always using the one defined in the config