codecov-commenter
commented
7 months ago Codecov Report
Attention: 136 lines in your changes are missing coverage. Please review.
Comparison is base (
6ddd5f3) 74.69% compared to head (cb80eb9) 74.41%.:exclamation: Current head cb80eb9 differs from pull request most recent head 20179b2. Consider uploading reports for the commit 20179b2 to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #380 +/- ## ========================================== - Coverage 74.69% 74.41% -0.28% ========================================== Files 101 103 +2 Lines 6417 6450 +33 ========================================== + Hits 4793 4800 +7 - Misses 1624 1650 +26 ``` | [Flag](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | `74.41% <33.00%> (-0.28%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Generic catching of http errors on requests now also catches the errors thrown by
aiohttpIn the case of retrieval, there is more logic that goes into making requests (there may be a single request, just like there may be 3 of them)
Therefore, a different
task_creatoris used (can be found inBlueBrainNexus)The entire logic of retrieval is located inside a co-routine (async-await block), see
_retrieve. In the case of single resource retrieval, we force a blocking call. In the case of multiple resources retrieval, a differenttask_creatoris provided toBatchRequest.batch_request, one that schedules tasks that are based on the asynchronous retrieval logic.TODO: figure out how to return errors of failed retrievals. Right now, it's through an empty resource and its _last_action says it was not successful. If None is returned instead, there should be a way to propagate the error to the user still (other than just printing)