search

BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

improved deflatten function (lower time complexity) #395

Closed NicoRicardi closed 5 months ago

NicoRicardi commented 5 months ago

This new version, which stems from @ssssarah linking me to this post, has a better time complexity.

lecriste commented 5 months ago

Tests are failing

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.55%. Comparing base (ded4d2c) to head (57e152f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #395 +/- ## ========================================== - Coverage 75.57% 75.55% -0.02% ========================================== Files 103 103 Lines 6644 6636 -8 ========================================== - Hits 5021 5014 -7 + Misses 1623 1622 -1 ``` | [Flag](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/395/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/395/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | `75.55% <100.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

NicoRicardi commented 5 months ago

Fixed the linting, tests pass now