Closed ssssarah closed 4 months ago
Attention: Patch coverage is 24.63768%
with 104 lines
in your changes are missing coverage. Please review.
Project coverage is 74.76%. Comparing base (
d2604cc
) to head (b3c1540
).
Files | Patch % | Lines |
---|---|---|
...forge/specializations/stores/nexus/http_helpers.py | 21.49% | 84 Missing :warning: |
utils.py | 16.66% | 20 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hmm why to call things: previous_sdk_usage.py
? why not just something generic about the methods there? and just comment/docstring that this was previois sdk usage. May be one can call it https_helpers.py
or something on those lines, it's just ... the name is too specific, "previous" and "sdk" ... I dunno ...
I've put all the code from the sdk that was used in the file previous_sdk_usage, with the change that the endpoint and token are provided as parameters (as opposed to setting environment variables)
No design thought really went into this, it's a fast solution, up to change
(preparatory work so that we specify a token as a callable, without having to handle setting the nexussdk environment variable)