BlueBrain / nexus-forge

Building and Using Knowledge Graphs made easy
https://nexus-forge.readthedocs.io
GNU Lesser General Public License v3.0
38 stars 19 forks source link

Parallelize validate #418

Closed ssssarah closed 3 weeks ago

ssssarah commented 2 months ago
codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 95.06173% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.19%. Comparing base (a1ae462) to head (19e3556).

Files Patch % Lines
kgforge/specializations/models/rdf/service.py 95.34% 2 Missing :warning:
...gforge/specializations/models/rdf/store_service.py 0.00% 1 Missing :warning:
kgforge/specializations/models/rdf_model.py 97.22% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #418 +/- ## ========================================== + Coverage 74.13% 74.19% +0.05% ========================================== Files 106 106 Lines 6979 6998 +19 ========================================== + Hits 5174 5192 +18 - Misses 1805 1806 +1 ``` | [Flag](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/418/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | `74.19% <95.06%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ssssarah commented 1 month ago

Unfortunately I ran into an issue when testing validation on 4000 resources. Long story short, pyshacl uses rdflib, rdflib uses pyparsing and it is not thread safe https://github.com/RDFLib/rdflib/issues/765 I'll look more into it