codecov-commenter
commented
3 weeks ago Codecov Report
Attention: Patch coverage is 9.60000% with 113 lines in your changes missing coverage. Please review.
Project coverage is 73.88%. Comparing base (
4a0ee65) to head (813689a).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| kgforge/specializations/stores/bluebrain_nexus.py | 6.32% | 74 Missing :warning: |
| ...cializations/stores/nexus/batch_request_handler.py | 13.33% | 39 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #420 +/- ## ========================================== - Coverage 74.19% 73.88% -0.31% ========================================== Files 106 106 Lines 6998 7034 +36 ========================================== + Hits 5192 5197 +5 - Misses 1806 1837 +31 ``` | [Flag](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/420/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/BlueBrain/nexus-forge/pull/420/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain) | `73.88% <9.60%> (-0.31%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BlueBrain#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
2 (main+metadata through resource endpoint) or 3 (main fail through resource endpoint, main+metadata through resolver endpoint) requests were necessary to retrieve resources:
Remove async force complete for retrieval of one resource. Synchronous requests are now used, since the body of the function is simpler, a little bit of duplication doesn't hurt as much.
To avoid the client session staying open too long, leading to a ServerDisconnectedError. + all tasks/resources no longer share the same client session (a batch of tasks/resources per client session)
When using the resource endpoint, the annotate query parameter only works for regular resources. It fails if we attempt to retrieve a schema with it. The best thing would be to use the schema endpoint with the annotate query parameter but that isn't supported by delta yet. So the mechanism to retrieve data (not source) + metadata, then data (source) without metadata, and then to merge them has been kept in a retrieve_schema method.
https://github.com/BlueBrain/nexus/pull/5079 RDFModel's validate uses the resource retrieve implementation to get schemas and ontologies. It was not possible to use the annotate query parameter in order to retrieve schemas through the resource endpoint until this change in the API.