BlueBrain / nexus

Blue Brain Nexus - A knowledge graph for data-driven science
https://bluebrainnexus.io/
Apache License 2.0
274 stars 73 forks source link

Only support valid Delta URIs (encoded) #2603

Open adulbrich opened 2 years ago

adulbrich commented 2 years ago

As reported by @MFSY:

Currently, I have to write (this might cause issues on clients) [as value to distribution.contentURL e.g.]:

https://bbp.epfl.ch/nexus/v1/files/bbp/lnmce/https://bbp.epfl.ch/neurosciencegraph/data/fd68fe86-2424-42df-b4e4-d110d59bc805

Instead of (which is the best/preferred way of having HTTP URLs as paths in a URL):

https://bbp.epfl.ch/nexus/v1/files/bbp/lnmce/https%3A%2F%2Fbbp.epfl.ch%2Fneurosciencegraph%2Fdata%2Ffd68fe86-2424-42df-b4e4-d110d59bc805

Affected (or to check) plugins:

Acceptance Criteria:

Not in scope:

adulbrich commented 2 years ago

@MFSY are you comfortable with the acceptance criteria above? do you want to keep backward compatibility?

adulbrich commented 2 years ago

@MFSY any feedback on this?

adulbrich commented 2 years ago

@dhaneshnm come up with list of examples to show impact for DKE (notify them once we have it)

MFSY commented 2 years ago

Hi,

Find below a description of this issue from my perspective. First of all, this is a bug to fix and not a feature request from my side.

Currently when display resources in some plugins, an already url encoded _self value is url encoded again leading to a double url encoding. The value of the resource _self property:

With this in mind, it would important to detect on the plugins side when it is already url encoded so that double url encoding is not happening.

Best.