search

BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language
https://bluebrain.github.io/nmodl/
Apache License 2.0
52 stars 15 forks source link

Remove deprecated `pkg_resources` #1166

Closed JCGoran closed 6 months ago

JCGoran commented 6 months ago

The pkg_resources submodule of setuptools is deprecated, and importlib should be used instead (or its backports, importlib_metadata and importlib_resources).

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.38%. Comparing base (9df433b) to head (8362dcc). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1166 +/- ## ======================================= Coverage 88.38% 88.38% ======================================= Files 176 176 Lines 12946 12946 ======================================= Hits 11442 11442 Misses 1504 1504 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #195553 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #195554 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #195668 (:white_check_mark:) have been uploaded here!

Status and direct links:

JCGoran commented 6 months ago

@pramodk I've added unit tests for the example from the README and caught a few issues along the way, should be okay now.

JCGoran commented 6 months ago

Minor annoyance (similar to #1165): if we merge this, we need to update the Spack recipe with py-importlib-metadata and py-importlib-resources (only if we test on Python 3.8, if not, you can ignore this).

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.17%. Comparing base (1baa906) to head (8375255).

:exclamation: Current head 8375255 differs from pull request most recent head 6ace4d8. Consider uploading reports for the commit 6ace4d8 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1166 +/- ## ======================================= Coverage 87.17% 87.17% ======================================= Files 175 175 Lines 12884 12884 ======================================= Hits 11232 11232 Misses 1652 1652 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #196504 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #196523 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #196575 (:white_check_mark:) have been uploaded here!

Status and direct links: