BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language
https://bluebrain.github.io/nmodl/
Apache License 2.0
53 stars 15 forks source link

Implement NONSPECIFIC_CURRENT. #1185

Closed 1uc closed 7 months ago

1uc commented 7 months ago

This commits adds a test for NONSPECIFIC_CURRENT and implements the codegen for NEURON required to pass the test.

It does not set the conductances.

1uc commented 7 months ago

PR for updating references: https://github.com/BlueBrain/nmodl-references/pull/4

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 28.66242% with 112 lines in your changes are missing coverage. Please review.

Project coverage is 86.58%. Comparing base (fbf9de6) to head (d89ff0a). Report is 1 commits behind head on master.

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 27.74% 112 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1185 +/- ## ========================================== - Coverage 87.17% 86.58% -0.60% ========================================== Files 175 175 Lines 12885 13006 +121 ========================================== + Hits 11233 11261 +28 - Misses 1652 1745 +93 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 7 months ago

Logfiles from GitLab pipeline #196601 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 7 months ago

Logfiles from GitLab pipeline #196850 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 7 months ago

Logfiles from GitLab pipeline #196889 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 7 months ago

Logfiles from GitLab pipeline #197105 (:white_check_mark:) have been uploaded here!

Status and direct links: