BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language
https://bluebrain.github.io/nmodl/
Apache License 2.0
53 stars 15 forks source link

Fail for invalid `<<` reaction equation. #1204

Closed 1uc closed 6 months ago

1uc commented 7 months ago

The previous behaviour for

KINETIC states {
     ~ x + y << 42.0
}

was to print a warning and continue as if the line didn't exist. The new behaviour is to throw an error, because it's unclear why ignoring the line could ever lead to a correct translation of the MOD file.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.57%. Comparing base (347f786) to head (da6f6f6). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1204 +/- ## ========================================== - Coverage 86.58% 86.57% -0.01% ========================================== Files 175 175 Lines 13006 13002 -4 ========================================== - Hits 11261 11257 -4 Misses 1745 1745 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 7 months ago

Logfiles from GitLab pipeline #199095 (:white_check_mark:) have been uploaded here!

Status and direct links: