Fix indexed COMPARTMENT block.

BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language

https://bluebrain.github.io/nmodl/

Apache License 2.0

49 stars 15 forks source link

Fix indexed COMPARTMENT block. #1209

Closed 1uc closed 4 months ago

1uc commented 4 months ago

When encountering an indexed COMPARTMENT block:

COMPARTMENT i, volume_expr { species }

All state variables are searched if they match they match the pattern "{species}[%d]". For each matching state variables, we obtain the value of the array index and substitute the name of the array index with its value in volume_expr. This is then stored in the array of compartment factors.

If multiple species are listed, the above happens for each (array-valued) species.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.60%. Comparing base (c8818c8) to head (9720681).

:exclamation: Current head 9720681 differs from pull request most recent head ce1ba0b. Consider uploading reports for the commit ce1ba0b to get more accurate results

Files	Patch %	Lines
src/visitors/kinetic_block_visitor.cpp	94.44%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1209 +/- ## ========================================== + Coverage 86.55% 86.60% +0.04% ========================================== Files 176 176 Lines 13017 13047 +30 ========================================== + Hits 11267 11299 +32 + Misses 1750 1748 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.