BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language
https://bluebrain.github.io/nmodl/
Apache License 2.0
53 stars 15 forks source link

Add minor fixes to generate_references on MacOS #1228

Closed JCGoran closed 6 months ago

JCGoran commented 6 months ago

For some reason, the previous version treated the quotation marks as literal, so it kept littering the references dir with backup files which had '' appended to it. This one expands the variables properly (thanks bash for arrays!). Also, realpath may not exist on MacOS (of course...) so I've replaced it with cd "$(dirname "$0")"; pwd -P which should do the same thing cross-platform.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.57%. Comparing base (87da423) to head (c3c881f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1228 +/- ## ======================================= Coverage 86.57% 86.57% ======================================= Files 176 176 Lines 13049 13049 ======================================= Hits 11297 11297 Misses 1752 1752 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 6 months ago

Logfiles from GitLab pipeline #201376 (:white_check_mark:) have been uploaded here!

Status and direct links: