BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language
https://bluebrain.github.io/nmodl/
Apache License 2.0
48 stars 15 forks source link

Update usecase tests so they compare outputs with NOCMODL #1231

Closed JCGoran closed 1 month ago

JCGoran commented 3 months ago

This PR modifies the testing of usecases as follows:

All of the above should allow us to catch any differences between NEURON + NOCMODL and NEURON + NMODL (with NEURON codegen) a bit more easily.

Note that the nonspecific current test is not modified until #1218 is merged as the test fails.

1uc commented 3 months ago

This type of diffing has caused considerable pain in the past, in is in many ways the opposite of what I'd like to build.

If there's a particular test success when is should fail, then the test should be made more strict. Once we implement enough functionality we'll gain access to ModelDB CI which does these types of checks.

bbpbuildbot commented 3 months ago

Logfiles from GitLab pipeline #203118 (:white_check_mark:) have been uploaded here!

Status and direct links: