Fix array variables. - Githubissues

BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language

https://bluebrain.github.io/nmodl/

Apache License 2.0

48 stars 15 forks source link

Fix array variables. #1233

Closed 1uc closed 2 months ago

1uc commented 3 months ago

These are the code generation changes required for:

https://github.com/neuronsimulator/nrn/pull/2779

The solution is to fill nrn_prop_param_size with the number of doubles, not number of variables.

bbpbuildbot commented 3 months ago

Logfiles from GitLab pipeline #203719 (:white_check_mark:) have been uploaded here!

Status and direct links:

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.56%. Comparing base (b78c3f3) to head (13a8e03). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1233 +/- ## ======================================= Coverage 86.56% 86.56% ======================================= Files 176 176 Lines 13170 13175 +5 ======================================= + Hits 11400 11405 +5 Misses 1770 1770 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 3 months ago

Logfiles from GitLab pipeline #203782 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #206108 (:white_check_mark:) have been uploaded here!

Status and direct links: