search

BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language
https://bluebrain.github.io/nmodl/
Apache License 2.0
48 stars 15 forks source link

Launch Python embedded interpreter only if using sympy #1241

Closed alkino closed 2 months ago

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #205487 (:no_entry:) have been uploaded here!

Status and direct links:

1uc commented 2 months ago

We need to check that it can still compile a MOD file containing a KINETIC block. The suspicion is that a KINETIC block will ask for sympy even if the subcommand sympy wasn't requested.

The other question is if we can do away with the initialization code entirely. I think there's a singleton that represents "access to Python". Maybe we can initialize the singleton properly when we first use it (and no sooner).

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #205973 (:white_check_mark:) have been uploaded here!

Status and direct links:

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 86.50%. Comparing base (b78c3f3) to head (bef0df9).

:exclamation: Current head bef0df9 differs from pull request most recent head 081ac76. Consider uploading reports for the commit 081ac76 to get more accurate results

Files Patch % Lines
src/main.cpp 5.26% 18 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1241 +/- ## ========================================== - Coverage 86.56% 86.50% -0.06% ========================================== Files 176 176 Lines 13170 13171 +1 ========================================== - Hits 11400 11393 -7 - Misses 1770 1778 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #206012 (:no_entry:) have been uploaded here!

Status and direct links:

1uc commented 2 months ago

I tried to find places where the embedded Python is used, but I only found the Sympy related stuff. Then I check if Sympy is used within a different visitor; but didn't find anything.

Therefore, this looks correct to me.