Improvements for handling python bindings CMake option

pramodk commented 2 months ago

If -DNMODL_ENABLE_PYTHON_BINDINGS=OFF then there is no need to generate AST and other wrapper classes for Pybind11.
Using sympy-based solvers does not require Python bindings to be enabled. Avoid confusing warning when using nmodl binary.
When someone tries to use the nmodl module via Python, the warning is still preserved.

# before
$ nmodl mod_examples/sparse.mod
[NMODL] [warning] :: Python bindings are not available with this installation
..

# with this PR
$ nmodl mod_examples/sparse.mod
$ python3.11 -c "import nmodl"
[NMODL] [warning] :: Python bindings are not available with this installation

Next Step (Independent of this PR): * disable Python bindings in NRN build for normal neuron+coreneuron build

@matz-e / @ohm314: I think this is finally clarified.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.50%. Comparing base (f6821ce) to head (f65fee0).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1244 +/- ## ======================================= Coverage 86.50% 86.50% ======================================= Files 176 176 Lines 13176 13176 ======================================= Hits 11398 11398 Misses 1778 1778 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #206984 (:white_check_mark:) have been uploaded here!

Status and direct links:

BlueBrain / nmodl

Improvements for handling python bindings CMake option #1244

Codecov Report