Bug fix for NEURON wheel creation

BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language

https://bluebrain.github.io/nmodl/

Apache License 2.0

48 stars 15 forks source link

Bug fix for NEURON wheel creation #1245

Closed pramodk closed 2 months ago

pramodk commented 2 months ago

when neuron is built with nmodl then nmodl related files should be installed in <prefix>/ and not in <prefix>/nmodl/.data
- <prefix>/nmodl/.data is used when we build standalone wheels
add one mod file using sparse solver - nmodl will automatically use sympy solver

This was the root cause for neuronsimulator/nrn/issues/2494!

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.67%. Comparing base (8eb88e4) to head (001673a).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1245 +/- ## ========================================== + Coverage 86.50% 86.67% +0.16% ========================================== Files 176 176 Lines 13176 13176 ========================================== + Hits 11398 11420 +22 + Misses 1778 1756 -22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #207066 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #207099 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #207353 (:white_check_mark:) have been uploaded here!

Status and direct links:

pramodk commented 2 months ago

The CI is green on NEURON side: https://dev.azure.com/neuronsimulator/nrn/_build/results?buildId=11802&view=results