Move common codegen code to parent class `CodegenCppVisitor`

BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language

https://bluebrain.github.io/nmodl/

Apache License 2.0

48 stars 15 forks source link

Move common codegen code to parent class `CodegenCppVisitor` #1251

Closed JCGoran closed 1 month ago

JCGoran commented 2 months ago

Some of the codegen routines are identical for NEURON and coreNEURON, so we may as well put them in the parent class, notably:

~~print_function_or_procedure~~ (EDIT: removed for now due to the need for workarounds for v in NEURON codegen)
print_table_replacement_function (code in #1247 does not actually need modifying)
print_table_check_function
get_table_statement
check_if_var_is_array
print_function_declaration

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #209636 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 months ago

Logfiles from GitLab pipeline #209739 (:white_check_mark:) have been uploaded here!

Status and direct links:

codecov-commenter commented 2 months ago

Files	Patch %	Lines
src/codegen/codegen_cpp_visitor.cpp	98.66%	2 Missing :warning:

```diff @@ Coverage Diff @@ ## master #1251 +/- ## ========================================== - Coverage 86.36% 86.35% -0.01% ========================================== Files 176 175 -1 Lines 13227 13214 -13 ========================================== - Hits 11423 11411 -12 + Misses 1804 1803 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #210557 (:white_check_mark:) have been uploaded here!

Status and direct links:

BlueBrain / nmodl

Move common codegen code to parent class `CodegenCppVisitor` #1251

Codecov Report