Fix PROCEDUREs using TABLEs containing the same var

BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language

https://bluebrain.github.io/nmodl/

Apache License 2.0

48 stars 15 forks source link

Fix PROCEDUREs using TABLEs containing the same var #1280

Closed JCGoran closed 1 month ago

JCGoran commented 1 month ago

Also adds a test to it.

Context

In https://github.com/BlueBrain/nmodl/pull/1247#issuecomment-2135697968 we found out that the same variable cannot be used in multiple TABLE statements using NOCMODL, so this PR adds a run-time check that prohibits this in NMODL as well.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.24%. Comparing base (a61bebf) to head (c5d24ce).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1280 +/- ## ========================================== + Coverage 86.22% 86.24% +0.01% ========================================== Files 178 178 Lines 13281 13299 +18 ========================================== + Hits 11452 11470 +18 Misses 1829 1829 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #213375 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #213387 (:white_check_mark:) have been uploaded here!

Status and direct links: