BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language
https://bluebrain.github.io/nmodl/
Apache License 2.0
53 stars 15 forks source link

Fix missing null-terminator. #1291

Closed 1uc closed 4 months ago

1uc commented 4 months ago

Would have been detectable with ASAN enabled version of NRN.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.49%. Comparing base (b4ef537) to head (aea54c0). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1291 +/- ## ========================================== - Coverage 85.50% 85.49% -0.02% ========================================== Files 178 178 Lines 13446 13449 +3 ========================================== + Hits 11497 11498 +1 - Misses 1949 1951 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 4 months ago

Logfiles from GitLab pipeline #214490 (:white_check_mark:) have been uploaded here!

Status and direct links:

1uc commented 4 months ago

This fixes a memory leak? If so, what's a MWE that would demonstrate the problem?

No, it fixes an out-of-bounds access. It's covered many times already; but without an NRN with ASAN enabled (or similar) there's no guarantee that it results in a failure (e.g. SEGFAULT).