Remove generation of INCLUDE file in the tests

BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language

https://bluebrain.github.io/nmodl/

Apache License 2.0

48 stars 15 forks source link

Remove generation of INCLUDE file in the tests #1295

Closed pramodk closed 1 month ago

pramodk commented 1 month ago

include mod files generation cause race condition with parallel tests, see #1290
the included files are trivial examples and they don't need to be generated from the code
- could be copied via configure_file
- cmake could generate those at a configure time

Considering the use case and it's triviality, I thought 2nd option is better. That also allows removal of some extra code/logic.

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #214643 (:white_check_mark:) have been uploaded here!

Status and direct links:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.49%. Comparing base (5366532) to head (e593a93). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1295 +/- ## ======================================= Coverage 85.49% 85.49% ======================================= Files 178 178 Lines 13448 13436 -12 ======================================= - Hits 11497 11487 -10 + Misses 1951 1949 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 1 month ago

Logfiles from GitLab pipeline #214695 (:white_check_mark:) have been uploaded here!

Status and direct links: