search

BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language
https://bluebrain.github.io/nmodl/
Apache License 2.0
48 stars 15 forks source link

Modernize NMODL -> Python layer. #1306

Closed 1uc closed 3 weeks ago

1uc commented 4 weeks ago

The changes are:

bbpbuildbot commented 4 weeks ago

Logfiles from GitLab pipeline #215737 (:no_entry:) have been uploaded here!

Status and direct links:

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 68.85246% with 19 lines in your changes missing coverage. Please review.

Project coverage is 85.46%. Comparing base (c5ecfea) to head (bc5b76c).

Files Patch % Lines
src/pybind/pyembed.cpp 22.72% 17 Missing :warning:
src/visitors/main.cpp 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1306 +/- ## ========================================== - Coverage 85.54% 85.46% -0.08% ========================================== Files 178 178 Lines 13415 13372 -43 ========================================== - Hits 11476 11429 -47 - Misses 1939 1943 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 4 weeks ago

Logfiles from GitLab pipeline #215749 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 4 weeks ago

Logfiles from GitLab pipeline #215785 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 4 weeks ago

Logfiles from GitLab pipeline #215815 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 4 weeks ago

Logfiles from GitLab pipeline #215821 (:white_check_mark:) have been uploaded here!

Status and direct links:

1uc commented 3 weeks ago

Double checked the issue about PYTHONPATH and at least locally it's not required. Plus it should get tests via the Spack-powered CI (since everything is then added via PYTHONPATH).

bbpbuildbot commented 3 weeks ago

Logfiles from GitLab pipeline #216169 (:white_check_mark:) have been uploaded here!

Status and direct links: