Pin numpy max version to <2

BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language

https://bluebrain.github.io/nmodl/

Apache License 2.0

48 stars 15 forks source link

Pin numpy max version to <2 #1322

Closed JCGoran closed 2 weeks ago

JCGoran commented 2 weeks ago

NMODL counterpart of https://github.com/neuronsimulator/nrn/pull/2916. Since NEURON first installs its own Python requirements, and only afterwards the requirements of its external dependencies, we need to merge this one first, then update and merge https://github.com/neuronsimulator/nrn/pull/2900, and finally merge https://github.com/neuronsimulator/nrn/pull/2916.

1uc commented 2 weeks ago

We can test this by updating the submodule in https://github.com/neuronsimulator/nrn/pull/2916 to this commit. If that passes we know we can merge this, update the submodule on the NEURON side again and merge that commit. Then close https://github.com/neuronsimulator/nrn/pull/2900.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.37%. Comparing base (a7bf7d9) to head (e182707).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1322 +/- ## ======================================= Coverage 85.37% 85.37% ======================================= Files 178 178 Lines 13436 13436 ======================================= Hits 11471 11471 Misses 1965 1965 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 2 weeks ago

Logfiles from GitLab pipeline #217189 (:white_check_mark:) have been uploaded here!

Status and direct links:

JCGoran commented 2 weeks ago

Since NEURON NMODL submodule didn't require patching, and it seems to work fine with NumPy 2, I'm closing this as I don't see any issues with using it.