search

BlueBrain / nmodl

Code Generation Framework For NEURON MODeling Language
https://bluebrain.github.io/nmodl/
Apache License 2.0
48 stars 15 forks source link

Include solvers to avoid include path dependency. #1329

Closed matz-e closed 2 hours ago

matz-e commented 3 days ago

Similar to #1305, include the solver headers in variables in a C++ header, and include them in the code generated for the MOD files. This should allow to substitute different NMODL binaries in NEURON builds without confusion as to which solver headers are going to be included in the MOD file compilation.

Tested in neuronsimulator/nrn#2953

CI_BRANCHES:NEURON_BRANCH=nmodl-include-header-cleanup

bbpbuildbot commented 3 days ago

Logfiles from GitLab pipeline #219813 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 3 days ago

Logfiles from GitLab pipeline #219836 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 3 days ago

Logfiles from GitLab pipeline #219874 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 days ago

Logfiles from GitLab pipeline #219972 (:no_entry:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 2 days ago

Logfiles from GitLab pipeline #220020 (:white_check_mark:) have been uploaded here!

Status and direct links:

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.37%. Comparing base (7beaee9) to head (a57ede4).

Files Patch % Lines
src/codegen/codegen_coreneuron_cpp_visitor.cpp 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1329 +/- ## ======================================= Coverage 85.37% 85.37% ======================================= Files 178 178 Lines 13458 13459 +1 ======================================= + Hits 11490 11491 +1 Misses 1968 1968 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bbpbuildbot commented 1 day ago

Logfiles from GitLab pipeline #220262 (:white_check_mark:) have been uploaded here!

Status and direct links:

bbpbuildbot commented 1 day ago

Logfiles from GitLab pipeline #220283 (:white_check_mark:) have been uploaded here!

Status and direct links: