SimConfig: preserve the order of modifications

BlueBrain / sonata-extension

https://sonata-extension.readthedocs.io/en/latest/

Apache License 2.0

3 stars 4 forks source link

SimConfig: preserve the order of modifications #55

Closed WeinaJi closed 4 months ago

WeinaJi commented 4 months ago

The modifications section should be similar to connection_overrides that they are applied in the order as being read from the config file. This PR aims to change the data struct of this section from dictionary to list in order to preserve the order.

WeinaJi commented 4 months ago

@andrisecker , do you use modificatiions in your simulations? If so, please have a look if this change makes sense for you

WeinaJi commented 4 months ago

Thanks for clarifying that.

modifications specified at different times would of course override following the temporal order.

This feature is required by https://bbpteam.epfl.ch/project/issues/browse/BBPBGLIB-762. I will open another PR to add the "delay" parameter in modifications.