search

BlueBrain / voxcell

Tools to work with voxel based brain atlases.
Apache License 2.0
5 stars 3 forks source link

Add a function to compute the spatial intersection of a segment with a VoxelData object #5

Closed adrien-berchet closed 2 years ago

eleftherioszisis commented 2 years ago

A segment is a morphological segment?

adrien-berchet commented 2 years ago

No, it is a spatial segment defined by two points, e.g. [[0, 0, 0], [1, 1, 1]]

eleftherioszisis commented 2 years ago

I see, thanks for the clarification!

adrien-berchet commented 2 years ago

You're welcome :)

adrien-berchet commented 2 years ago

Hey there, Is it possible to merge this and release a new version please?

mgeplf commented 2 years ago

Sorry, this fell off my radar.

I want to go through the math a bit better, but should happen soon.

adrien-berchet commented 2 years ago

Ok, no problem :)

I pushed a new commit to add the requested comment (https://github.com/adrien-berchet/voxcell/commit/21dd411922b6a262ac010323ad583faea4e80303) but it does not appear here. Do you know why? :thinking:

mgeplf commented 2 years ago

I pushed a new commit to add the requested comment (adrien-berchet/voxcell@21dd411) but it does not appear here. Do you know why?

Not sure; also, I can't make changes to the PR, so it would be helpful to allow maintainers to change it, if you can check that box.

adrien-berchet commented 2 years ago

The box is already checked

adrien-berchet commented 2 years ago

Maybe it's because this PR was opened when the repository was private and the fork sync was kinda lost when it was made public? I made my fork public too but it didn't fix this issue.

mgeplf commented 2 years ago

The box is already checked

Strange, because I can push to the branch. Was this PR made before the repo was public? I don't know.

I added you with write access to the repo; if you want to push the branch here, that will probably be easier.

adrien-berchet commented 2 years ago

Ok, I opened a new PR with the new commit: #11