search

BlueBubblesApp / BlueBubbles-Desktop-App

A desktop app for BlueBubbles to run on Linux, Windows, and others!
47 stars 8 forks source link

Enable auto scroll when receiving new message #228

Closed trueblooda closed 3 years ago

trueblooda commented 3 years ago

This functionality was in the code already, it was just commented out.

Adding this feature will help bluebubbles match its iOS design philosophy.

zlshames commented 3 years ago

Hey, can you edit this PR to be to the development branch? I just created it as it probably was needed to properly allow contributors to contribute

mwaldrich commented 3 years ago

Hey, can you edit this PR to be to the development branch? I just created it as it probably was needed to properly allow contributors to contribute

Sure, do you mean merge into BlueBubblesServer:development? Or merge from trueblooda:develoment?

Also, while this does work, I want to prevent the auto scroll from happening when the user is scrolled up a certain amount of pixels. Could you modify this so that the auto scroll will only occur if the current scroll is within X (maybe 50px) of the bottom?

Can do, we'll ping you when it's done

zlshames commented 3 years ago

Hey, can you edit this PR to be to the development branch? I just created it as it probably was needed to properly allow contributors to contribute

Sure, do you mean merge into BlueBubblesServer:development? Or merge from trueblooda:develoment?

Also, while this does work, I want to prevent the auto scroll from happening when the user is scrolled up a certain amount of pixels. Could you modify this so that the auto scroll will only occur if the current scroll is within X (maybe 50px) of the bottom?

Can do, we'll ping you when it's done

Switch the destination to the BlueBubblesAndroidApp:development branch. It's ok to push from your master

mwaldrich commented 3 years ago

@zlshames We made the scroll change. We found that a scroll threshold of 50px was wayyyy too small. It wouldn't scroll one message above. We made the threshold 2000px which will auto-scroll you when you're looking about a page of messages up from the bottom

mwaldrich commented 3 years ago

We also change the merge branch