1.11 Checklist

[tneotia]

• [x] Rewrite ChatBloc - reduce logic significantly (only save to DB, don't update UI, consolidate methods)
• [x] Rewrite MessageBloc - reduce logic significantly (only save to DB, don't update UI, consolidate methods)
• [x] Rewrite queues
• [x] Rewrite LifeCycleManager
• [x] Rewrite NotificationManager
• [x] Rewrite ActionHandler
• [x] Verify ChatManager / ChatController / MessageManager are in a good state (otherwise rewrite)
• [x] Rewrite methods in Attachment, Message, and Chat models (consider adding to the new Chat / Message / Attachment services?)
• [x] Consolidate helpers
  • [x] Remove unused methods
  • [x] Create standardized files for each helper type (e.g. string helper, color helper, etc)
  • [x] UI Rewrite
  • [x] Message view
    • [x] Reply lines
    • [x] Typing indicator
    • [x] Message popup (and related)
    • [x] Bubble colors
    • [x] Contact info + photo
    • [x] Message effects
    • [x] View past edits
  • [x] Chat creator
  • [x] See TODOs in code
  • [x] attributed body and message summary info samples for the following:
  • [x] Digital Touch
  • [x] Apple Music
  • [x] Apple Pay
  • [x] GamePigeon
  • [x] Any other imessage app thingy
  • [x] Message with multiple parts (ie, message, then attachment, then message, etc) with parts unsent and edited and reacted to and replied to and mentions and sticker applied - this will be kept as the holiest of all messages
  • [x] Reply to a message with a message with multiple parts (not sure how it determines which part of the message attaches as a reply)
  • [x] screenshots of all of the above, plus:
  • [x] chat details (for group chat)
• [x] full sync stack overflow
• [x] disable sending attachments when replying
• [x] verify sharing to app or direct chat works (when backgrounded AND fully closed)
• [x] verify opening chat from notif works (when backgrounded AND fully closed)
• [x] verify replying to notif works (when backgrounded AND fully closed)
• [x] verify mark as read from notif works (when backgrounded AND fully closed)
• [x] When in redacted mode, real contact names still show up in conversation previews with tapbacks
• [x] https://discord.com/channels/640229510662455326/746692766167334963/1051994193234501762
• [x] On my Z Fold 4 when clicking on an already open chat on the left this occurs consistently.

So far the animations are so sweet and just from a quick conversation with my GF she and I both can tell it's much faster and seemless. I'm loving it!

Another thing I noticed is that the typing indicator for when the other person is typing is only showing on the chat list and not in the chat.

• [x] This version is definitely smoother and nicer looking. Well done.

Some feedback: Font Size Scaling bars would look better if they all had the same size and alignment. Also, it would be nice to have a master slider that moved all of them at once.

• [x] Also removing a reaction doesn't display it removed
• [x] So a kinda weird thing that doesn't hurt anyone but in the latest Android app the "Attach recent photo" button gets multiplied a bunch if you go into the other attachments menu
• [x] material chat highlight is bugged
• [ ] I think that interactive message and blank messages are just redacted mode messing with links. Here it is with and without.
• [x] picture:
• [x] find ways to improve reliability of typing status - maybe check every so often that the chat is actually typing?
• [x] sending multiple attachments in one go is bugged
• [x] marking chat read is borked if read receipts off for that specific chat but auto mark private api on
• [x] Failed to render active chat issue
• [x] noticed a bug. when you're in a chat, and the person responds, the app registers it as a new message and shows the number on the back arrow to indicate a new message. even though the "new message" is the chat you're currently in and are looking at
• [x] Pick contact when adding person to gc doesnt work
• [x] Reply to a notification can send repeatedly - maybe send "reply to message" guid to dart and dont send if already replied to message?
• [x] material chat title still shows as bold even though read
• [x] cannot go from system - > brightness of current system theme
• [x] material theme status bar brightness light mode is borked
• [x] status indicators showing as none
• [x] more contrast on reply bubble text iOS
• [x] smart replies don't do anything when tapped

[zlshames]

Here's my own list:

• [x] Fix refresh rate configuration (this is still not fixed)
• [x] Email contacts and phone numbers with a +1 country code (or any country code?) don't match correctly
• [x] Multiple sent messages show the delivered timestamp. Only one should (the latest)
• [x] Send animation's placeholder widget isn't in the right spot
• [x] When avatars in chat are enabled, they are not aligned correctly in the message view
• [x] Message bubbles with a single character have a weird shape. Should set a min width I assume.
• [x] When recording audio, the stop icon is like 1px offset
• [x] Can we make the audio recording widget be the same size and same location as the normal message box. Basically so it overlays on top of it all (except the stop button)
• [x] Contact card widget needs more spacing between the name and the avatar. Probably need to look into making sure the widget is dynamic if the name takes up 2 lines
• [x] Attachment send widget's size text moves to a second line and not centered. Should be either centered or small enough font to stay on one line
• [x] Sent images do not load into the message view once sent. You need to back-out and re-enter
• [x] Rename Download to Device to Save.
• [x] Move the Share option to be higher priority than Redownload from server
• [x] When an attachment is last message in a chat, the message preview in chat list is empty after entering the chat and leaving it.
• [x] We should be able to start the slide to reply to a message, but cancel the reply by backtracking the slide
• [x] When a tall image's context menu is opened via a tap and hold, the send reaction bar overlaps the existing reactions header
• [x] In material mode, pinned chat icon is not in a consistent location
• [x] Remove beta indicator from Samsung theme
• [x] Samsung theme's starred chat icon (pinned) is not in a consistent location. Should probably be to the right of the timestamp
• [x] The server connection status in connection settings is all lowercase on the Samsung theme. It should match the styling of the other statuses (all caps)
• [x] Loading a search from the server result is broken. It gets stuck loading surrounding messages
• [x] Loading a search result from the local device is broken. Lots of grey boxes.
• [x] Full Material You mode might cause the bubble color and background color to be the same within the chat preview window. Not in real chat messages view
• [x] Contact Card messages do not show in the message preview in the chat list
• [x] Make animation when a new message arrives slower. It's just too fast imo, I think making it slower also is more similar to iOS. Makes things feel more jelly-y
• [x] Contact cards (VCFs) with a name but no phone numbers/emails does not show properly. It will show "Unknown"
• [x] Make sure that attachments sent to yourself doesn't break sync or crash app due to relationship constraints
• [x] Reduce font size and center number text within the new messages badge when I'm a chat
• [x] Selecting a reaction does not auto close the message details
• [x] When a new-message event comes in, and the message isFromMe, clear notifications on Android device for that chat. If you already responded on another device, it should clear the notifications for that chat
• [x] Big Emojis are broken
• [x] Reactions break the message widgets in chat preview window
• [x] FIXED IN BUNDLE Reactions sent on messages with multiple parts (i.e. image with text or links with text), do not show on iOS. Only show as a notification
• [x] Reaction bubble should be a little bigger. Maybe 2-4px more in diameter. I was comparing to iOS and it looks slightly bigger
• [x] Sharing contact VCF doesn't work
• [x] Is it on purpose that all chat last messages get reloaded when leaving another chat?
• [x] Sharing an attachment to an unopened chat (and not previously open), doesn't load the attachment into the picker properly
• [x] After initial full sync, connection to the server shows disconnected until app is closed and re-opened
• [x] When settings are restored from server/file, the settings page should update with the latest setting values
• [x] When viewing replies, should we add a shadow or outline to the received messages? They look too similar to the background blur color
• [x] Opening an image in the fullscreen viewer does not show the correct image (this might partially be to multi-part messages; or when the multi-part message has videos & images)
• [x] Spacing between sent message and received message before/after it should be more
• [x] Message bubbles should span 3/4 the width. Right now we only do 50% the screen width I think. But on iPhones it's more like 75%
• [x] Need more padding above the keyboard. Aka between the text field and message view
• [x] Marking a chat as unread doesn't work using the chat preview context menu
• [x] The share menu icon on iOS theme should be a filled icon rather than the outline icon
• [x] The audio recording icon on iOS theme should be the outline icon
• [x] Reduce spacing between pinned avatars and chat titles
• [x] Reduce font size of pinned chat titles by 1px or 2px. (i.e. the chat title "Breakfast Book Club" should be able to be seen in full, and on one line)
• [x] The last message timestamps in the chat list should align with the chat titles. Aka, at the top right of the chat title. This is especially apparent when the last message spans 2 lines
• [x] CANNOT DO The last message text preview should be allowed to span the entire chat tile
• [x] In the new chat creator, switching to and from iMessage/SMS should clear the participants list, and any search term entered
• [x] In new chat creator, DMs should take precedence over groups chats in the search results
• [x] In the new chat creator, iMessage chats should not show when SMS is selected, and vice versa. This includes when a search term is typed
• [x] In the new chat creator, DMs should show the address of the recipient as the chat tile's subtitle
• [x] In the new chat creator, rename SMS to "SMS Forwarding" to make it clear we don't fully support SMS yet
• [x] Add some more padding under the iMessage/SMS selector and chat list in the new chat creator
• [x] Sharing to the app when the app is fully closed does not work
• [x] I don't think reactions should overlay on top of the senders name. I think on iOS it pushes the name up higher
• [x] New chat creator is completely broken for me now. Big grey box in the chat list widget. And no logs in logging
• [x] The chat preview subtitle text now extends too far. It needs some padding on the right side so it stops before the edge of the tile
• [x] Sending an image duplicates in chat, and then disappears, showing a nearly blank image download widget. Steps: send an image, wait for it to send. It will duplicate. Then send a message after, and there will be a download widget where the initial image was
• [x] Fix replies UI. Aka, show just the line only when the reply is to the latest received message. Otherwise, always display the originally replied to message bubble
• [x] Typing indicator (on light mode) don't have enough contrast. Colors seem off
• [x] Reactions in the chat list preview sometimes nest itself within another reaction text
• [x] When the app is open to the chat list, and an image is received the chat preview text is blank
• [x] Sending a message while an image is sending causes the image send widget to disappear
• [x] When switching to 120hz, then leaving the settings page, the refresh rate gets reset to Auto (when re entering the settings page)
• [x] Reduce spacing between pinned chats and non pinned chats (iOS skin)
• [ ] (Low Priority) Emojis show up as Chinese characters when exported in a transcript
• [x] The camera button that shows above the chat creator button (when enabled) is broken
• [x] Remove fake name/message content generator toggles in redacted mode if we no longer want to support that
• [x] Verify that all redacted mode options operate as they describe
• [x] After enabling/disabling redacted mode, then backing out to the main settings page, the redacted mode status doesn't update on the settings tile
• [x] When typing indicators are visible, message send animation isn't as smooth because it animates to the normal spot, then snaps up above the typing indicators.
• [x] SMS Forwarding colors should not use theming colors imo, and should just be the ugly SMS green color
• [x] New chat creator subtitle phone numbers should be formatted
• [x] Video mute behavior settings needs top and bottom padding
• [x] Reduce padding between sender name and reactions on the message bubble
• [x] Add padding to selected reply UI
• [x] Link Preview widgets don't seem to load in immediately and can cause Chat last message preview issues
• [x] GUID cache for notifications
• [x] (It's there, just has an entirely new UI) Connection indicator missing from conversation view header
• [x] new message count badge is still inaccurate sometimes. Happened to me when entering a chat, it didn't clear the unread badge. Either that or it was just way too slow
• [x] in new chat creator, if u type and select a name, then begin to type another name, but delete it, you can't send a message to the first recipient. It happened to me because I selected a contact and tried to then type my message, but realized the message text field wasn't selected. I wasn't able to send a message after that.
• [x] in new message creator (light theme), the iMessage/SMS tab button colors aren't contrasted enough
• [x] Message previews are not always correct. I think the last message getter cache needs a rework
• [x] Opening a notification when the app is already open breaks the app (full grey screen)
• [x] chats with a single messages show the new message loader indefinitely
• [x] sometimes when a chat is open (pinned), and then returning the the chat list, the notification dot is gone, but the last message preview still persists
• [x] when chat avatars are enabled and typing indicators show, then go away, the avatar stays in the message view
• [x] replies do not show the message that was replied to
• [ ] sometimes when entering a conversation through a notification, images do not show after being downloaded. The download UI just gets to 100% and nothing happens until a new message is received (or leaving the chat and re entering)
• [x] unread notifications no longer show properly. Reproduce by getting text from 2 diff chats while the app is backgrounded. Open one of them. You should have an unread badge, but you don't. This happens when starting from the chat list too
• [x] notifications from different chats don't show the same in the notification shade. One chat may have a large avatar and the other might have a small one
• [x] nitpick: reduce spacing between chat titles text and pinned chat avatar to match iOS
• [x] biometric unlock only works when the app is resumed, not when fully closed and opened
• [x] when sending an image with text, make sure the image sends first
• [x] connection indicator doesnt show in the conversation view or chat list
• [ ] audio widget in default light mode needs to be darker (waveform)
• [x] nitpick: increase spacing between reply message bubble & replied to bubble
• [ ] replies via a notification on the lock screen show as from the original sender. Not from "you"
• [ ] nitpick: sometimes double delivered messages. Not sure why. Hard to reproduce
• [x] hyperlink previews duplicate when first viewed in a chat. Most cases seem to duplicate it 3 times
• [x] remove the 1px left padding from the unread badge count
• [x] group event text is not centered
• [x] update chat titles when group name change event is received
• [x] reports that settings/theme imports do not work/do anything
• [x] better error logging: https://docs.flutter.dev/testing/errors
• [ ] add participant contact selector doesn't allow search

[davlsb]

• [x] Swipe settings are not unavailable but the settings for them still appear
• [ ] Dividers don't always render correctly? sometimes a line may be half missing

[gettingerr]

• [x] Tablet Mode dubplicated in settings menu when in "Tablet Mode" on Galaxy Z Fold 4

• [x] Tablet Mode causes press and hold menu to appear off screen

[warmpigman]

• [x] When in a group chat, I should be able to edit/create a new contact by either holding down on their pfp/contact name or holding down on a message and having an option in the popup that can edit/create a new contact.

[jjoelj]

Couple things for material skin that I've noticed in Google messages

• [x] show reply icon to the inside of message when showing reaction popup (in addition to swipe)
• [x] swipe to reply should be default as well
• [x] Messages that are sent but not yet delivered in latest message text are italicized
• [x] Sent messages in latestmessagetext start with "You: "
• [x] show message timestamps as [time] • Read/Delivered or "Sending..." (with animated ellipses but that's not too important)
• [x] always show most recent message timestamp even if it is not from me
• [x] Timestamps in convo view say "Now" up until 1 min "X min" until 59 min (I think), and then "hh:mm AM/PM" for the rest of the current day, then e.g "Wed 3:54 PM" until the previous current day of week, then, within a year, e.g "May 4, hh:mm PM", and everything else "MM/DD/YY hh:mm PM"
• [x] Timestamps in chat list say "Just Now" instead of "Now", the "X min" are the same. Within a week, it's the 3-character day of week. Within the year, it's e.g. "Mar 3". Anything older is MM/DD/YY
• [x] NOT DOING DUE TO LAG CONCERNS This might be harder: when the latest message is an attachment, the latest text says something like "picture" and a preview of the image shows in a square on the right of the convo tile. The date doesn't show.
• [x] also there's a scroll to top button in the chat list once you scroll down
• [x] read indicator and typing are positioned wrong on ios pins.
• [x] read indicator shows for the wrong pinned chats (should be for chats to latestmessage fromme)
• [x] turning off redacted mode doesn't bring contact names back to normal until app restart
• [ ] message drafts don't reset properly
• [x] chat list shows 'sent' in convos where the latest message wasn't fromme
• [ ] connection indicator gradient should be a little more opaque while in ios convo view. Gets mixed in with the blur and not noticeable sometimes. Especially if message bubbles are a reddish color
• [x] can't switch to system theme if it matches light/dark selection. (i.e if my phone is in dark mode and the app has dark theme selected, can't switch to system theme.

[zlshames]

My new checklist:

• [ ] nitpick: for sent videos, the audio button should be moved a little more left so it doesn't collide with the edge of the bubble
• [ ] nitpick: initials in avatars need to be 1 px lower (only in conversation view header)
• [ ] replies in notification shade show as from the sender (not from me)