BlueBubblesApp / bluebubbles-server

Server for forwarding iMessages to clients within the BlueBubbles App ecosystem
https://bluebubbles.app
Apache License 2.0
554 stars 47 forks source link

[Feature Request] Deduping requests #673

Open dolfies opened 4 months ago

dolfies commented 4 months ago

This feature request kinda applies to both client/server but I didn't really know where to put it, sorry if it's in the wrong place.

When a request errors, the message is sometimes sent anyway on the server side (usually happens when the error is a result of spotty internet on the client's part). When a user retries the request, these messages are duplicated. I propose a nonce is sent with every unique request, allowing the server to drop duplicate requests that have already succeeded, even if the client didn't think so. This would also allow unobtrusive auto request retrying as the main issue of duplication would be resolved. Thank you for your work!

mehapps commented 3 months ago

Personally like the idea with a nonce (just generate a unique hash that isn't dependent on the message, low chance of collision) and it could be an optional parameter for now to avoid being a breaking change