Support for sails v0.11

BlueHotDog / sails-migrations

The missing, migrations, arm of the octopus

MIT License

158 stars 37 forks source link

Support for sails v0.11 #64

Closed tibotiber closed 8 years ago

tibotiber commented 9 years ago

Hi! I'm trying to use this with sails v0.11. I've done really basic stuff so far without any problem. Do you know of any issue that may arise later on? Is the README to be updated (it indicates support up to 0.10.5)? Not sure whether the v0.10 to v0.11 upgrade has affected any of the aspects this lib relies on...

TylerBre commented 9 years ago

Does not support v0.11

sails-migrations status              
path.js:488
      throw new TypeError('Arguments to path.join must be strings');
            ^
TypeError: Arguments to path.join must be strings
  at Object.posix.join (path.js:488:13)
  at Function.SailsIntegration.getSailsConfig

etc.

looks like the adapter can't get the sailsConfig, and it looks like versions are hardcoded

I would love to submit a pr, but I have no idea how to dev on this. Running the tests just spits out npm errors??

sortegam commented 9 years ago

RWOverdijk commented 9 years ago

:+1:

BlueHotDog commented 9 years ago

Hi guys, unfortunately i do not have any capacity to look into this issue right now, any PRs are welcome.

niallobrien commented 8 years ago

Has anyone isolated the issue?

joaosa commented 8 years ago

I submitted a PR that addresses this :)

BlueHotDog commented 8 years ago

merged, will push a new version later on.

On Thu, Oct 29, 2015 at 8:47 AM João Sousa Andrade notifications@github.com wrote: I submitted a PR that addresses this :)

— Reply to this email directly or view it on GitHub .

RWOverdijk commented 8 years ago

awesome!

joaosa commented 8 years ago

I have a production build depending on this. Is there any chance you could make the release? :)

BlueHotDog commented 8 years ago

@joaosa published.