Why do you need to change letter case, how now to output fields by their original names?

BlueM / Tree

PHP library for handling tree structures based on parent IDs, e.g. a self-joined database table

237 stars 46 forks source link

Why do you need to change letter case, how now to output fields by their original names? #49

Open scion4581 opened 3 months ago

scion4581 commented 3 months ago

https://github.com/BlueM/Tree/blob/ded69515db52cb95afd9655d632bfffc6494641c/src/Tree/Node.php#L40C9-L40C76

BlueM commented 3 months ago

This was a deliberate decision (quite some time ago) with the goal to make access via getters case-insensitive with minimal performance overhead. (See #32) Nowadays, I’d wouldn’t implement it like that anymore, and it’s very likely that this will change in the next major version.

TheDigitalOrchard commented 2 months ago

@BlueM Are you teasing us with a "next major version" hint in there? Is there active development happening?

Will you accept pull requests from the community to help move this project forward? Then we could help address suggestions like mentioned here.

BlueM commented 2 months ago

@TheDigitalOrchard: there hadn’t been active development for a long time, but as it became increasingly obvious the code could need some modernizations, I’ve started working on some improvements recently. Among other things, in my local Git repo, the properties are no longer normalized to lowercase.

It’s very likely I will push the changes to a v4 branch, so anyone who is interested can experiment with it before a v4 is tagged, and potentially submit PRs.