search

BlueManCZ / SIF

:video_game: Steam Icons Fixer - Fix runtime icons of Steam games on Linux.
Apache License 2.0
46 stars 3 forks source link

Source SDK modified into... discord-577632370602278912.desktop ? #2

Closed PoorPocketsMcNewHold closed 3 years ago

PoorPocketsMcNewHold commented 3 years ago 
SIF on  master via  v3.8.5 
❯ ./sif.py --icons
These icons for your installed Steam games were found in Papirus-Dark icon theme:

  Counter-Strike - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_10.svg
~ Team Fortress Classic - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_20.svg
  Day of Defeat - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_30.svg
  Deathmatch Classic - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_40.svg
~ Half-Life: Opposing Force - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_50.svg
~ Half-Life - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_70.svg
  Counter-Strike: Condition Zero - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_80.svg
~ Half-Life: Blue Shift - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_130.svg
~ Half-Life 2 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_220.svg
  Counter-Strike: Source - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_240.svg
  Half-Life 2: Deathmatch - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_320.svg
  Half-Life 2: Lost Coast - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_340.svg
~ Half-Life Deathmatch: Source - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_360.svg
  Half-Life 2: Episode One - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_380.svg
~ Portal - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_400.svg
  Half-Life 2: Episode Two - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_420.svg
~ Team Fortress 2 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_440.svg
~ Left 4 Dead 2 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_550.svg
* Dota 2 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_570.svg
* Portal 2 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_620.svg
* Counter-Strike: Global Offensive - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_730.svg
  Killing Floor - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_1250.svg
  Garry's Mod - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_4000.svg
* BioShock Infinite - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_8870.svg
  LIMBO - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_48000.svg
  Borderlands 2 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_49520.svg
  Spec Ops: The Line - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_50300.svg
  Amnesia: The Dark Descent - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_57300.svg
  Terraria - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_105600.svg
* Crusader Kings II - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_203770.svg
  Castle Crashers - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_204360.svg
  Sanctum 2 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_210770.svg
  PAYDAY 2 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_218620.svg
* Insurgency - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_222880.svg
  POSTAL 2 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_223470.svg
  No More Room in Hell - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_224260.svg
~ Euro Truck Simulator 2 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_227300.svg
  Company of Heroes 2 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_231430.svg
  POSTAL - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_232770.svg
  War Thunder - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_236390.svg
  Outlast - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_238320.svg
  Amnesia: A Machine for Pigs - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_239200.svg
  Skullgirls - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_245170.svg
* Cities: Skylines - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_255710.svg
  Borderlands: The Pre-Sequel - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_261640.svg
  Broforce - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_274190.svg
* A Story About My Uncle - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_278360.svg
  Tabletop Simulator - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_286160.svg
  F1 2015 - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_286570.svg
  Lovely Planet - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_298600.svg
  Robocraft - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_301520.svg
  Floating Point - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_302380.svg
  Unturned - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_304930.svg
* DiRT Rally - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_310560.svg
  Double Action: Boogaloo - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_317360.svg
  Portal Stories: Mel - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_317400.svg
  Don't Starve Together - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_322330.svg
* Black Mesa - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_362890.svg
  Blender - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_365670.svg
  DOOM - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_379720.svg
* Teeworlds - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_380840.svg
  POSTAL Redux - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_401680.svg
  Godot Engine - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_404790.svg
  Becalm - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_999830.svg
  Classic Racers - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_1037480.svg
* Dota Underlords - /usr/share/icons/Papirus-Dark/48x48/categories/steam_icon_1046930.svg

* - game is in our database and can be fixed
~ - game is fixable, but we have to edit its launch options

SIF on  master via  v3.8.5 
❯ ./sif.py --pretend
Installed games whose icons can be fixed:

     20 - Team Fortress Classic
     50 - Half-Life: Opposing Force
     70 - Half-Life
    130 - Half-Life: Blue Shift
    220 - Half-Life 2
    360 - Half-Life Deathmatch: Source
    400 - Portal
    440 - Team Fortress 2
    550 - Left 4 Dead 2
    570 - Dota 2
    620 - Portal 2
    730 - Counter-Strike: Global Offensive
   8870 - BioShock Infinite
 203770 - Crusader Kings II
 222880 - Insurgency
 227300 - Euro Truck Simulator 2
 255710 - Cities: Skylines
 278360 - A Story About My Uncle
 310560 - DiRT Rally
 362890 - Black Mesa
 380840 - Teeworlds
1046930 - Dota Underlords

No changes were made because --pretend option was used.

SIF on  master via  v3.8.5 
❯ ./sif.py
Creating .desktop files in /home/pm/.local/share/applications/steam-icons-fixed

Running Steam instance was found.
It is necessary to exit Steam for some changes to take effect.

Would you like to terminate Steam now? [Y/n]: Y

Terminating Steam processes.

     20 * - Team Fortress Classic
     50 * - Half-Life: Opposing Force
     70 * - Half-Life
    130 * - Half-Life: Blue Shift
    220 * - Half-Life 2
    360 * - Half-Life Deathmatch: Source
    400 * - Portal
    440 * - Team Fortress 2
    550 * - Left 4 Dead 2
    570   - Dota 2
    620   - Portal 2
    730   - Counter-Strike: Global Offensive
   8870   - BioShock Infinite
 203770   - Crusader Kings II
 222880   - Insurgency
 227300 * - Euro Truck Simulator 2
 255710   - Cities: Skylines
 278360   - A Story About My Uncle
 310560   - DiRT Rally
 362890   - Black Mesa
 380840   - Teeworlds
1046930   - Dota Underlords

 * - added fix to game launch options
Could not parse file "/home/pm/.local/share/applications/discord-577632370602278912.desktop": Key file contains line ? %u? which is not a key-value pair, group, or comment

SIF on  master via  v3.8.5 took 10s 
❯ cd /home/pm/.local/share/applications

.local/share/applications 
❯ ls
'An Octave Higher - Basic Soundtrack.desktop'     'Driftland The Magic Revival - Soundtrack.desktop'  'Half-Life 2 Episode Two Soundtrack.desktop'                 lstopo.desktop                                              picom.desktop                                             'SPLIT BULLET Original Soundtrack.desktop'                     'Unhack - Original Soundtrack.desktop'
 arandr.desktop                                   'Dying Light Original Soundtrack.desktop'           'Half-Life 2 Soundtrack.desktop'                            'Lucid9 - Soundtrack.desktop'                               'Portal 2 Soundtrack.desktop'                              'Squids Odyssey Soundtrack.desktop'                            'Unruly Heroes - Soundtrack.desktop'
'Audio Party Pack.desktop'                         electron4.desktop                                  'Half-Life 2 Update.desktop'                                'Master of Orion Soundtrack & Score.desktop'                'Portal Soundtrack.desktop'                                'Squirm OST.desktop'                                           'Unsung Kingdom Soundtrack.desktop'
'Beholder - Original Soundtrack.desktop'           electron5.desktop                                  'Half-Life Soundtrack.desktop'                              'Meegah Mem II Official Soundtrack.desktop'                 'POSTAL 2.desktop'                                         'Stardust Galaxy Warriors - Strike Update Soundtrack.desktop'  'Until You Fall - A Swordwave OST.desktop'
'Blast Rush Original Soundtrack.desktop'           electron6.desktop                                  'Halfquake Trilogy Complete Soundtrack.desktop'              mimeinfo.cache                                             'Probe Soundtrack.desktop'                                  steam-icons-fixed                                              urxvtc.desktop
"bob's game.desktop"                               electron7.desktop                                   hardcode-fixer.desktop                                      mintstick.desktop                                          'Project DeepWeb Soundtrack.desktop'                       'Steam Summer Monsters Soundtrack.desktop'                      urxvt-tabbed.desktop
' Bonus Track.desktop'                             electron8.desktop                                   hardinfo.desktop                                           'Mission Demolition - Soundtrack.desktop'                   'Project Genesis Soundtrack.desktop'                       'Steam Summer Saliens Soundtrack.desktop'                       userapp-Nightly-J4FOP0.desktop
 bssh.desktop                                      electron9.desktop                                  'Have a N.I.C.E day! Soundtrack.desktop'                    'Monster RPG 3 Soundtrack.desktop'                          'QT Soundtrack.desktop'                                    'SubDivide Soundtrack.desktop'                                  volumeicon.desktop
 bvnc.desktop                                      electron.desktop                                    hidamari.desktop                                           'Monument Soundtrack.desktop'                                quick-system-info.desktop                                 'Super Arcade Racing  Soundtrack.desktop'                       vsls-launcher.desktop
 ca.desrt.dconf-editor.desktop                    'Enderal - Original Soundtrack.desktop'             'Hotline Miami Soundtrack.desktop'                          'Music To Go POSTAL By.desktop'                              qv4l2.desktop                                             'SUPERHOT MIND CONTROL DELETE Soundtrack.desktop'              'Walden, a game - Soundtrack.desktop'
"Clean'Em Up OST.desktop"                         'Epic Battle Fantasy 3 - Soundtrack.desktop'         htop.desktop                                               'N.I.C.E. 2 Soundtrack.desktop'                             "Sable's Grimoire A Dragon's Treasure Soundtrack.desktop"  'TAL Arctic 3 - Soundtrack.desktop'                            'Wallpaper Engine.desktop'
'Colum and His Friends Soundtrack.desktop'        'Evil Cult Soundtrack.desktop'                      'Human Resource Machine Soundtrack.desktop'                  nitrogen.desktop                                           "Sable's Grimoire Man And Elf Soundtrack.desktop"          'Tallowmere  Soundtrack.desktop'                               'WARPZONE DRIFTER.desktop'
 compton.desktop                                  'Flat Trip OST and Art.desktop'                     'ICEY OST.desktop'                                          'Nyanco Channel Soundtrack.desktop'                         "Sable's Grimoire Soundtrack.desktop"                      'The Dota 2 Remixes EP.desktop'                                'Winter Polaris C97 Drama CD.desktop'
 conky.desktop                                    'Freakshow soundtrack.desktop'                      'Jelly Brawl Classic.desktop'                               'Nyanco Dream Soundtrack.desktop'                           'Samorost 2 Soundtrack.desktop'                            'The Executioner Soundtrack.desktop'                           'World of Art - learn with Jigsaw Puzzles Soundtrack.desktop'
'Counter-Strike Global Offensive.desktop'         'Free to Play Soundtrack.desktop'                   'Keep the Balance Soundtrack.desktop'                        obconf.desktop                                             'Scanner Sombre Original Soundtrack.desktop'               'The Search Soundtrack.desktop'                                'World of Goo Soundtrack.desktop'
'Cyber Seraph Soundtrack.desktop'                 'Frostpunk Original Soundtrack.desktop'             'Kingdom Under Fire  Heroes Soundtrack.desktop'              obkey.desktop                                              'Scythe Digital Edition - Soundtrack.desktop'              'The Void Rains Upon Her Heart - Soundtrack.desktop'           'World of Warships  Composers Choice.desktop'
'Cymatically Muffed - Soundtrack.desktop'         'Fruit Postal Service.desktop'                      'Kingdom Under Fire The Crusaders  Soundtrack.desktop'       obmenu3.desktop                                            'Sector Six OST.desktop'                                   ' The Wind Road Soundtrack.desktop'                             yad-icon-browser.desktop
'Das Geisterschiff Remixed.desktop'                gparted.desktop                                    'Kinoko Soundtrack.desktop'                                 'Odyssey Soundtrack.desktop'                                '  Servants of Harvest Wish Soundtrack.desktop'             tint2conf.desktop                                              ZACH-LIKE.desktop
'Dear Devere Soundtrack.desktop'                   grub-customizer.desktop                             kite-copilot.desktop                                       'Oh My Girl   Soundtrack.desktop'                           'Session Seven Soundtrack.desktop'                          tint2.desktop                                                 'Zatorski, Ph.D. Soundtrack.desktop'
'DEEP SPACE ANOMALY Soundtrack + ART.desktop'     'G String Sample Soundtrack.desktop'                 kite.desktop                                               'One Thousand Lies Soundtrack.desktop'                      'Skeletal Dance Party - Soundtrack.desktop'                'Tomboys Need Love Too! Soundtrack.desktop'                    'Zombie Panic! Source Official Soundtrack.desktop'
'Demon King Domination - Soundtrack.desktop'       gtk-lshw.desktop                                   'Leaving Lyndow Original Soundtrack.desktop'                 org.gnome.DiskUtility.desktop                              'Slimey Champions Soundtrack.desktop'                      'Tower Unite - Soundtrack.desktop'                             'Zup! 6 - OST.desktop'
'Desktop Agents - Cov1d-999 Soundtrack.desktop'   'Hacknet Official Soundtrack.desktop'               'Leon'\''s crusade (La cruzada de Len) Soundtrack.desktop'  'Ori and the Blind Forest (Additional Soundtrack).desktop'  'Sloth Heart to Heart Soundtrack.desktop'                  'Toy Robot Soundtrack.desktop'
'Die Again - Soundtrack.desktop'                  'Half-Life 2 Deathmatch.desktop'                    'Liberated Soundtrack Mixtape  Vol.1.desktop'               'OSK - Soundtrack.desktop'                                  'Smart Cube - Soundtrack.desktop'                           TTV3.desktop
"Dirty Harry's Thunder Drive Soundtrack.desktop"  'Half-Life 2 Episode One Soundtrack.desktop'        'Little Inferno Soundtrack.desktop'                         'Party Jousting.desktop'                                    'Spark & Sparkle Soundtrack.desktop'                        UBERMOSHOMEGA.desktop
 discord-577632370602278912.desktop               'Half-Life 2 Episode Two.desktop'                   'Logistique Soundtrack.desktop'                              pavucontrol.desktop                                        'Spark & Sparkle Soundtrack Extra Sounds.desktop'           UBERMOSHSANTICIDE.desktop

.local/share/applications 
❯ bat discord-577632370602278912.desktop 
───────┬───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: discord-577632370602278912.desktop
───────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ [Desktop Entry]
   2   │ Name=Game 577632370602278912
   3   │ Exec=/mnt/Ventilateur/SteamLibrary/steamapps/common/Source SDK Base 2013 Multiplayer/hl2_linux -game "/home/pm/.steam/steam/steamapps/sourcemods/open_fortress/" -novid -steam
   4   │  %u
   5   │ Type=Application
   6   │ NoDisplay=true
   7   │ Categories=Discord;Games;
   8   │ MimeType=x-scheme-handler/discord-577632370602278912;
───────┴───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

.local/share/applications 
❯

As you can see, for some weird reasons, sif.py modified my Source SDK Base 2013 Multiplayer .desktop shortcut, to Discord for some strange reason.

I can´t even really understand why the odd discord number. Is it conflicting with the Open Fortress game path ?

BlueManCZ commented 3 years ago

Hello,

sif.py script creates and modifies only .desktop files in ~/.local/share/applications/steam-icons-fixed. I did it this way to prevent corruption of already created .desktop files.

I noticed an error message in your output which says:

Could not parse file "/home/pm/.local/share/applications/discord-577632370602278912.desktop": Key file contains line ? %u? which is not a key-value pair, group, or comment

This error message is produced when the command update-desktop-database ~/.local/share/applications is executed. You can try it and confirm if I'm right.

It looks like this file discord-577632370602278912.desktop was already present before you ran the sif.py script. Didn't you use any others fixer scripts before?

BlueManCZ commented 3 years ago

By the way,

I see you have a lot of games whose icons are in Papirus ./sif.py --icons, but barely half of them is in the database of SIF and therefore can be fixed. You can contribute and add some of your games to the database if you would like, as described here.

PoorPocketsMcNewHold commented 3 years ago

I did use https://github.com/bil-elmoussaoui/Hardcode-Tray beforehand. I’ll close that issue since it’s indeed more likely to be caused by this one for hand. I’ll think about trying to push some additions to SIF in the future, for sure.

BlueManCZ commented 3 years ago

Hardcode-Tray doesn't touch .desktop files at all. But https://github.com/Foggalong/hardcode-fixer came to my mind.