search

BlueManCZ / edgets

Gentoo overlay that brings you the newest versions of modern software.
12 stars 8 forks source link

x11-libs/bamf: fix ebuilds #6

Closed nick87720z closed 3 years ago

nick87720z commented 3 years ago

First - even configuration failed. Now should work, but I found that test-bamf fails on make check (test-libbamf passes). Can't understand effect from --disable-gtktest.

BlueManCZ commented 3 years ago

Hello. That's strange. Both ebuilds 0.5.5 and 9999 emerge just fine for me as they are. But thank you for your contribution, I will look into it. Can you provide your error messages, please?

nick87720z commented 3 years ago

Without modifications - it's just configure, which can't find vapigen, because eclass sets it in VAPIGEN var, but configure expects VALA_API_GEN. This is all error I had.

Could be that you have vapigen unversioned executable, which is probably symlink? This could make it to work, but you could eventually find, that used unversioned vapigen has different version that e.g. valac, picked by configuration from VALAC variable.

Did not try live ebuild yet, only release.

BlueManCZ commented 3 years ago

Yes, you are right. I have vapigen symlinked to /usr/bin/vapigen-0.48. I tested live ebuild now and it works just fine. Thank you!

nick87720z commented 3 years ago

Perhaps would be better to rename dbusmenu use flag to dbus. The dbusmenu flat is only used by xfce4-panel from all packages, while plank uses dbus flag for same dependency (even your plank ebuild). I found it just now, while checking your plank ebuild, comparing with one from elementary repo, which I used before. Also I did not know (or forgot) xdg.eclass, using instead xdg-utils.eclass.

BlueManCZ commented 3 years ago

Also I did not know (or forgot) xdg.eclass, using instead xdg-utils.eclass.

What do you mean?

nick87720z commented 3 years ago

What do you mean?

Nevermind. I left it instead of some pointless recomentation about these eclasses.