BlueMap-Minecraft / BlueMap

A Minecraft mapping tool that creates 3D models of your Minecraft worlds and displays them in a web viewer.
https://bluecolo.red/bluemap
MIT License
1.84k stars 127 forks source link

Models are missing face shading #148

Open ChloeDawn opened 3 years ago

ChloeDawn commented 3 years ago

BlueMap Version: 1.3.0-forge-1.16.2

Description: Models rendered on the map lack directional shading on faces like is applied in Minecraft, sides being darker than the top, west/east being darker than north/south, and down being darker still.

In-game screenshot Map screenshot

TBlueF commented 3 years ago

I'll test around with adding some directional shades, if i manage to make something that looks good, i'll add it :)

TBlueF commented 3 years ago

One problem with adding those lights is blocks like tall grass.. if i add a directional light, tall-grass-blocks start looking very dark and not like ingame at all on bluemap:

left with directional-light, right current lighting image

ChloeDawn commented 3 years ago

Model elements have a "shade" flag that defaults to true when absent, stuff like the grass cross model and torches set it to false. Possibly you could parse that?

TBlueF commented 3 years ago

Well, that however means that this is a breaking change that needs model-changes ... so it's not going to happen as soon as i thought ^^